chore: replace local exec with azapi action #64
Conversation
lokesh-vadlamudi
requested review from
PengyuanZhao,
declanwilson-lw,
kirklandnuts,
lwmobeent and
michaelhsiehlw
kirklandnuts
left a comment
kirklandnuts
left a comment
There was a problem hiding this comment.
hi @lokesh-vadlamudi, can you please confirm all of the prior behavior is maintained? Specifically, I'm concerned about whether the container app start is always triggered on every terraform apply (including subsequent applies)?
| triggers_replace = { | ||
| always_run = timestamp() | ||
| } |
There was a problem hiding this comment.
This trigger_replace block ensures that this resource is always replaced on every terraform apply — i.e., this call is made during every terraform apply and the job will always execute immediately when terraform apply is run.
I don't see anything in the new code that would maintain this behavior. Can you please confirm that the behavior is maintained? If so, can you please also update the testing section in your PR description?
kirklandnuts
left a comment
kirklandnuts
left a comment
There was a problem hiding this comment.
thanks for addressing the issue @lokesh-vadlamudi - this LGTM 👍
3 participants
Summary
Replace local exec with azapi action.
Starting container app job instantly using Azure api instead of Azure cli.
This change eliminates the need to install and authenticate azure cli, which helps when executing this tf module in CI.
How did you test this change?
We can see runs in az portal
Issue